Allow same-kind casting of the result into out in dpnp.take and dpnp.compress#2959
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
|
coverage: 78.084% (-0.007%) from 78.091% — allow-same-kind-castiing-in-take into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_19 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
vlad-perevezentsev
approved these changes
Jun 22, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Jun 22, 2026
…p.compress (#2959) Previously `dpnp.take` and `dpnp.compress` raised a `TypeError` whenever the provided `out` array had a dtype different from the input array (strictly [followed](https://data-apis.org/array-api/latest/API_specification/generated/array_api.take.html) Python array API): > out (array) – an array having the same data type as x. This PR relaxes that check to allow casting the result into an `out` array of a **different but same-kind** dtype (e.g. `int32` -> `int64`, `int32` -> `float32`), aligning the behavior closer to dpnp documentation [clamming](https://intelpython.github.io/dpnp/reference/generated/dpnp.take.html): > It should be of the appropriate shape and dtype. and aligning with recent changes done in NumPy 2.5. c415cd6
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
dpnp.takeanddpnp.compressraised aTypeErrorwhenever the providedoutarray had a dtype different from the input array (strictly followed Python array API):This PR relaxes that check to allow casting the result into an
outarray of a different but same-kind dtype (e.g.int32->int64,int32->float32), aligning the behavior closer to dpnp documentation clamming:and aligning with recent changes done in NumPy 2.5.